yaooqinn commented on a change in pull request #28090: [SPARK-31321][SQL]
Remove SaveMode check in v2 FileWriteBuilder
URL: https://github.com/apache/spark/pull/28090#discussion_r402132872
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileWriteBuilder.scala
##########
@@ -68,26 +61,8 @@ abstract class FileWriteBuilder(
lazy val description =
createWriteJobDescription(sparkSession, hadoopConf, job, paths.head,
options.asScala.toMap)
- val fs = path.getFileSystem(hadoopConf)
- mode match {
- case SaveMode.ErrorIfExists if fs.exists(path) =>
Review comment:
e.g.
https://github.com/apache/spark/blob/8b01473e8bffe349b1ed993b61420d7d68896cd8/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala#L603
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
