CJStuart commented on a change in pull request #28156:
[SPARK-31388][SQL][TESTS] org.apache.spark.sql.hive.thriftserver.CliSuite
doesn't match results correctly
URL: https://github.com/apache/spark/pull/28156#discussion_r406035535
##########
File path:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
##########
@@ -172,7 +189,10 @@ class CliSuite extends SparkFunSuite with
BeforeAndAfterAll with BeforeAndAfterE
logError(message, cause)
fail(message, cause)
} finally {
- process.destroy()
+ if (!process.waitFor(1, MINUTES)) {
+ log.warn("spark-sql did not exit. Killing process.")
Review comment:
If the SQL repl keeps waiting for the next input this will always happen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
