juliuszsompolski commented on issue #28156: [SPARK-31388][SQL][TESTS] org.apache.spark.sql.hive.thriftserver.CliSuite doesn't match results correctly URL: https://github.com/apache/spark/pull/28156#issuecomment-611398620 @wangyum I pushed one more change: wait for the CLI process instead of killing it. Fail the test if it doesn't end gracefully. We are closing the stdin of the process, so it will exit. Now in many tests we do e.g.: ``` "DROP TABLE t1;" -> "", "DROP TABLE sourceTable;" -> "" ``` at the end. The empty line match at the end may still match on anything for that last drop table, because it actually finishes running. Let's wait and give it a chance to finish.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
