dongjoon-hyun commented on a change in pull request #28200:
[SPARK-31432][DEPLOY] bin/sbin scripts should allow to customize jars dir
URL: https://github.com/apache/spark/pull/28200#discussion_r407883142
##########
File path:
launcher/src/test/java/org/apache/spark/launcher/CommandBuilderUtilsSuite.java
##########
@@ -99,6 +99,11 @@ public void testJavaMajorVersion() {
assertEquals(10, javaMajorVersion("10"));
}
+ @Test
+ public void testGetJarsDir() {
+ assertEquals("/spark/home/jars", getJarsDir("/spark/home"));
Review comment:
Hi, @marblejenka .
This seems to add a half of the test coverage.
Since this PR's key contribution is to introduce `ENV_SPARK_JARS_DIR`, can
we have a test coverage for `ENV_SPARK_JARS_DIR`, too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
