dongjoon-hyun commented on a change in pull request #28200:
[SPARK-31432][DEPLOY] bin/sbin scripts should allow to customize jars dir
URL: https://github.com/apache/spark/pull/28200#discussion_r407889188
##########
File path:
launcher/src/main/java/org/apache/spark/launcher/CommandBuilderUtils.java
##########
@@ -315,7 +316,7 @@ static int javaMajorVersion(String javaVersion) {
*/
static String findJarsDir(String sparkHome, String scalaVersion, boolean
failIfNotFound) {
// TODO: change to the correct directory once the assembly build is
changed.
- File libdir = new File(sparkHome, "jars");
+ File libdir = new File(getJarsDir(sparkHome));
if (!libdir.isDirectory()) {
libdir = new File(sparkHome,
String.format("assembly/target/scala-%s/jars", scalaVersion));
if (!libdir.isDirectory()) {
Review comment:
Ur, this PR seems to cause a misleading error message when the user give a
wrong `SPARK_JARS_DIR`.
In case of a wrong `SPARK_JARS_DIR`, the error message should give the
user-given `SPARK_JARS_DIR` instead of `assembly/target/scala-%s/jars`. Could
you check this once more, @marblejenka ?
Also, it would be great if we can have a negative test coverage for the
above wrong `SPARK_JARS_DIR`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
