MaxGekk commented on a change in pull request #27498: [SPARK-30688][SQL] Week
based dates not being parsed with TimestampFormatter
URL: https://github.com/apache/spark/pull/27498#discussion_r408284532
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -99,12 +99,35 @@ private object DateTimeFormatterHelper {
new DateTimeFormatterBuilder().parseCaseInsensitive()
}
- def toFormatter(builder: DateTimeFormatterBuilder, locale: Locale):
DateTimeFormatter = {
- builder
- .parseDefaulting(ChronoField.MONTH_OF_YEAR, 1)
- .parseDefaulting(ChronoField.DAY_OF_MONTH, 1)
- .parseDefaulting(ChronoField.MINUTE_OF_HOUR, 0)
- .parseDefaulting(ChronoField.SECOND_OF_MINUTE, 0)
+ def setDefaulting(builder: DateTimeFormatterBuilder,
+ locale: Locale,
+ isWeekBased: Boolean = false): DateTimeFormatterBuilder =
{
Review comment:
Please, change the indentation as in the style guide
https://github.com/databricks/scala-style-guide#spacing-and-indentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
