MaxGekk commented on a change in pull request #27498: [SPARK-30688][SQL] Week
based dates not being parsed with TimestampFormatter
URL: https://github.com/apache/spark/pull/27498#discussion_r408283657
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala
##########
@@ -93,7 +93,8 @@ class LegacySimpleDateFormatter(pattern: String, locale:
Locale) extends LegacyD
object DateFormatter {
import LegacyDateFormats._
- val defaultLocale: Locale = Locale.US
+ // Default locale should be obtained from JVM defaults.
+ val defaultLocale: Locale = Locale.getDefault
Review comment:
Changing the default locale is slightly risky because it is involved in
resolving of short time zone names inside of DateTimeFormatter.
`Locale.US` is used in Spark SQL everywhere as default locale. I am
wondering why do you need to change it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
