hvanhovell commented on a change in pull request #28223: [SPARK-31450][SQL] Make ExpressionEncoder thread-safe URL: https://github.com/apache/spark/pull/28223#discussion_r408705978
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala ########## @@ -384,7 +407,7 @@ case class ExpressionEncoder[T]( override def toString: String = s"class[$schemaString]" - override def makeCopy: ExpressionEncoder[T] = copy() + override def makeCopy: ExpressionEncoder[T] = this Review comment: No. I can try to remove it, but we might break a 'public' API. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
