cloud-fan commented on a change in pull request #28223: [SPARK-31450][SQL] Make
ExpressionEncoder thread-safe
URL: https://github.com/apache/spark/pull/28223#discussion_r408708206
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -3649,9 +3649,8 @@ class Dataset[T] private[sql](
* Collect all elements from a spark plan.
*/
private def collectFromPlan(plan: SparkPlan): Array[T] = {
- // `ExpressionEncoder` is not thread-safe, here we create a new encoder.
- val enc = resolvedEnc.copy()
- plan.executeCollect().map(enc.fromRow)
+ val deserializer = resolvedEnc.createDeserializer()
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
