marblejenka commented on a change in pull request #28200: [SPARK-31432][DEPLOY]
bin/sbin scripts should allow to customize jars dir
URL: https://github.com/apache/spark/pull/28200#discussion_r409216232
##########
File path: pom.xml
##########
@@ -928,6 +928,18 @@
<version>0.11</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.stefanbirkner</groupId>
Review comment:
It is not impossible, but we have to do the same thing to test code that
uses environment variables. Consequently, we will include a copy of that
dependency (specifically
https://github.com/stefanbirkner/system-rules/blob/master/src/main/java/org/junit/contrib/java/lang/system/EnvironmentVariables.java
, which enables to write environment variable via reflection api) in our test
code.
The other way is giving up coverage, but I think it not desirable.
In my opinion, system-rules is beneficial for testing of environment
variables in other usecase. Additionally, there should be no problem with the
license, so I would like you to merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
