dongjoon-hyun commented on a change in pull request #28200: 
[SPARK-31432][DEPLOY] bin/sbin scripts should allow to customize jars dir
URL: https://github.com/apache/spark/pull/28200#discussion_r409224059
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -928,6 +928,18 @@
         <version>0.11</version>
         <scope>test</scope>
       </dependency>
+      <dependency>
+        <groupId>com.github.stefanbirkner</groupId>
 
 Review comment:
   `environmentVariables.set` is used only twice. I guessed the following will 
be enough for this PR. What do you think?
   ```java
       try {
         System.setProperty("SPARK_JARS_DIR", "...");
         // test code
       } finally {
         System.clearProperty("SPARK_JARS_DIR");
       }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to