cloud-fan commented on a change in pull request #28223: [SPARK-31450][SQL] Make
ExpressionEncoder thread-safe
URL: https://github.com/apache/spark/pull/28223#discussion_r409270503
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoderSuite.scala
##########
@@ -437,7 +437,7 @@ class ExpressionEncoderSuite extends
CodegenInterpretedPlanTest with AnalysisTes
testOverflowingBigNumeric(new BigInteger("9" * 100), "java very big int")
encodeDecodeTest("foo" -> 1L, "makeCopy") {
- Encoders.product[(String,
Long)].makeCopy.asInstanceOf[ExpressionEncoder[(String, Long)]]
Review comment:
we can remove this test as it was added to verify `makeCopy`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
