hvanhovell commented on a change in pull request #28223: [SPARK-31450][SQL] Make ExpressionEncoder thread-safe URL: https://github.com/apache/spark/pull/28223#discussion_r409397024
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/Encoder.scala ########## @@ -57,10 +57,6 @@ import org.apache.spark.sql.types._ * Encoders.bean(MyClass.class); * }}} * - * == Implementation == - * - Encoders are not required to be thread-safe and thus they do not need to use locks to guard - * against concurrent access if they reuse internal buffers to improve performance. - * Review comment: I think it should be thread-safe. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
