Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4993#discussion_r26325092
  
    --- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ---
    @@ -106,6 +106,35 @@ class SparkContextSuite extends FunSuite with 
LocalSparkContext {
           sc.stop()
         }
       }
    +  
    +  test("addFile works with relative path") {
    --- End diff --
    
    Rather than copy and paste the test I wonder if this can just be injected 
into the "addFile works" test. Like, make the test file a relative path there. 
Also I see that test doesn't use the framework provided temp dir which you did 
correctly here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to