Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4993#discussion_r26325517
  
    --- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ---
    @@ -106,6 +106,35 @@ class SparkContextSuite extends FunSuite with 
LocalSparkContext {
           sc.stop()
         }
       }
    +  
    +  test("addFile works with relative path") {
    --- End diff --
    
    I think it would be good to test both absolute and relative paths.  Maybe 
we can break the meat of the test out into a separate function and have both 
tests call it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to