maropu commented on a change in pull request #28294:
URL: https://github.com/apache/spark/pull/28294#discussion_r413431031
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -2033,62 +2036,11 @@ class Analyzer(
*/
object ResolveAggregateFunctions extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = plan.resolveOperatorsUp {
- case f @ Filter(cond, agg @ Aggregate(grouping, originalAggExprs,
child)) if agg.resolved =>
+ case AggregateWithHaving(cond, agg: Aggregate) if agg.resolved =>
Review comment:
Could you leave some comments here about why we need this special
handling for aggregate with having?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
