xuanyuanking commented on a change in pull request #28294:
URL: https://github.com/apache/spark/pull/28294#discussion_r413511664
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
##########
@@ -583,6 +583,16 @@ case class Aggregate(
}
}
+case class AggregateWithHaving(
Review comment:
```
move it into unresolved.scala?
```
Yeah, make sense, will change it to unresolved.scala.
```
Could we rename this into UnresolvedHaving
```
Since the `group by` not always come with `Aggregate`, it can also be
`GroupingSets`, we only handle the Aggregate part with `AggregateWithHaving`.
So maybe let's keep it `AggregateWithHaving`? WDYT :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
