Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/2851#discussion_r26392169
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -357,7 +357,13 @@ private[spark] class BlockManager(
info: BlockInfo,
status: BlockStatus,
droppedMemorySize: Long = 0L): Unit = {
- val needReregister = !tryToReportBlockStatus(blockId, info, status,
droppedMemorySize)
+ def ifAsync: Boolean = {
+ blockId.isBroadcast
+ }
+ // asynchronously report broadcast variables, in future we only need
to change the
+ // implementation of ifAsync
--- End diff --
I find this comment a little bit confusing -- it sounds like you are saying
there is future work still to do. Do you mean something like "Broadcast
variables are currently reported asynchronously, but if we later decide they
should be reported synchronously, we just need to update ifAsync`"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
