Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2851#discussion_r26393202
  
    --- Diff: 
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
    @@ -88,4 +88,19 @@ class StorageStatusListener extends SparkListener {
         }
       }
     
    +  override def onBlockUpdate(blockUpdateEvent: SparkListenerBlockUpdate) = 
synchronized {
    +    val executorId = blockUpdateEvent.blockManagerId.executorId
    +    updateStorageStatus(executorId, Seq((blockUpdateEvent.blockId,
    --- End diff --
    
    If I'm following things correctly, this will also get called for RDD 
blocks, which are already getting updated by `TaskEnd`.  I suppose its not a 
problem for them to get updated again with the same info, but you could 
probably skip the update for non-broadcast blocks, and include a comment as in 
`EventLoggingListener`.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to