Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/2851#discussion_r26395589
--- Diff: core/src/main/scala/org/apache/spark/ui/storage/RDDPage.scala ---
@@ -17,134 +17,84 @@
package org.apache.spark.ui.storage
-import javax.servlet.http.HttpServletRequest
-
import scala.xml.Node
-import org.apache.spark.storage.{BlockId, BlockStatus, StorageStatus,
StorageUtils}
-import org.apache.spark.ui.{WebUIPage, UIUtils}
+import org.apache.spark.storage.StorageUtils
+import org.apache.spark.ui.UIUtils
import org.apache.spark.util.Utils
/** Page showing storage details for a given RDD */
-private[ui] class RDDPage(parent: StorageTab) extends WebUIPage("rdd") {
- private val listener = parent.listener
-
- def render(request: HttpServletRequest): Seq[Node] = {
- val parameterId = request.getParameter("id")
- require(parameterId != null && parameterId.nonEmpty, "Missing id
parameter")
-
- val rddId = parameterId.toInt
- val storageStatusList = listener.storageStatusList
- val rddInfo = listener.rddInfoList.find(_.id == rddId).getOrElse {
- // Rather than crashing, render an "RDD Not Found" page
- return UIUtils.headerSparkPage("RDD Not Found", Seq[Node](), parent)
- }
+private[ui] class RDDPage(parent: StorageTab) extends
StorageDetailPage("rdd", parent) {
- // Worker table
- val workers = storageStatusList.map((rddId, _))
- val workerTable = UIUtils.listingTable(workerHeader, workerRow,
workers,
- id = Some("rdd-storage-by-worker-table"))
+ protected override val workerTableID: String =
"rdd-storage-by-block-table"
--- End diff --
by *worker*, not by *block*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
