sarutak commented on a change in pull request #28317:
URL: https://github.com/apache/spark/pull/28317#discussion_r414031863
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##########
@@ -88,7 +88,8 @@ private[ui] class AllJobsPage(parent: JobsTab, store:
AppStatusStore) extends We
// The timeline library treats contents as HTML, so we have to escape
them. We need to add
// extra layers of escaping in order to embed this in a Javascript
string literal.
val escapedDesc = Utility.escape(jobDescription)
- val jsEscapedDesc = StringEscapeUtils.escapeEcmaScript(escapedDesc)
+ val jsEscapedDescForTooltip =
StringEscapeUtils.escapeEcmaScript(Utility.escape(escapedDesc))
Review comment:
If we'd like to get a tooltip text `<console>`, the value of the
corresponding attribute `data-title` should be `<console>`.
With single `Utility.escape`, the value of attribute will be `<console>` so
additional `Utility.escape` is needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
