sarutak commented on a change in pull request #28317:
URL: https://github.com/apache/spark/pull/28317#discussion_r414057394
##########
File path: core/src/main/resources/org/apache/spark/ui/static/spark-dag-viz.js
##########
@@ -282,11 +282,7 @@ function renderDagVizForJob(svgContainer) {
/* Render the dot file as an SVG in the given container. */
function renderDot(dot, container, forJob) {
- var escaped_dot = dot
- .replace(/</g, "<")
- .replace(/>/g, ">")
- .replace(/"/g, "\"");
- var g = graphlibDot.read(escaped_dot);
+ var g = graphlibDot.read(dot);
Review comment:
In the current implementation, a source text is used for tooltip text as
HTML and used for node label as plain text for DAG Viz.
I changed the usage of the source text for node label to interpret it as
HTML.
So, I believe these escaping I remove from `renderDot` are not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
