mridulm commented on a change in pull request #28257:
URL: https://github.com/apache/spark/pull/28257#discussion_r414235678
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
##########
@@ -675,11 +676,15 @@ private[spark] class TaskSchedulerImpl(
// Check whether the barrier tasks are partially launched.
// TODO SPARK-24818 handle the assert failure case (that can happen
when some locality
// requirements are not fulfilled, and we should revert the launched
tasks).
- require(addressesWithDescs.size == taskSet.numTasks,
- s"Skip current round of resource offers for barrier stage
${taskSet.stageId} " +
Review comment:
@Ngone51 It is not whether there is user code is handling exception or
not - but throwing exception stops the flow of code here. If exception is not
thrown, rest of the code will execute - barrier initialization, flag updates,
log messages, etc.
Some of it gets cleaned up by taskset abort, some of it results in confusing
log messages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
