mridulm commented on a change in pull request #28257:
URL: https://github.com/apache/spark/pull/28257#discussion_r414238078
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
##########
@@ -675,11 +676,15 @@ private[spark] class TaskSchedulerImpl(
// Check whether the barrier tasks are partially launched.
// TODO SPARK-24818 handle the assert failure case (that can happen
when some locality
// requirements are not fulfilled, and we should revert the launched
tasks).
- require(addressesWithDescs.size == taskSet.numTasks,
- s"Skip current round of resource offers for barrier stage
${taskSet.stageId} " +
Review comment:
I definitely agree !
I was referring specifically in context of backport - not throwing an
exception results in behavior change, which we should not have.
Ideal solution is to fix this - the `require` was a precondition we were
expecting to be satisfied for barrier scheduling - which gets violated when
locality preference is present (which probably the original authors did not
expect/consider).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
