Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/5014#discussion_r26408757
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -585,34 +589,6 @@ private[hive] class HiveMetastoreCatalog(hive:
HiveContext) extends Catalog with
}
case p: LogicalPlan if p.resolved => p
-
- case p @ CreateTableAsSelect(db, tableName, child, allowExisting,
None) =>
--- End diff --
OK, I see your point, but it seems more reasonable to keep both
`CreateTableAsSelect` pattern matching, probably we can remove the duplicated
code for the first matching block, what do you think?
Hmm, and `hasStorageSpec` seems not right to me in previous implementation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
