dongjoon-hyun commented on a change in pull request #28328:
URL: https://github.com/apache/spark/pull/28328#discussion_r414681298
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -519,7 +519,9 @@ case class InSet(child: Expression, hset: Set[Any]) extends
UnaryExpression with
override def sql: String = {
val valueSQL = child.sql
- val listSQL = hset.toSeq.map(Literal(_).sql).mkString(", ")
Review comment:
This seems to be an orthogonal fix. @cloud-fan and @MaxGekk . We need
this in `branch-2.4` because this is SPARK-12593 (Converts resolved logical
plan back to SQL) since Apache Spark 2.0.0, don't we?
If you don't mind, please file a separate JIRA issue with a separate test
case. We need to merge this seperately.
cc @holdenk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
