MaxGekk commented on a change in pull request #28328:
URL: https://github.com/apache/spark/pull/28328#discussion_r414813908



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -519,7 +519,9 @@ case class InSet(child: Expression, hset: Set[Any]) extends 
UnaryExpression with
 
   override def sql: String = {
     val valueSQL = child.sql
-    val listSQL = hset.toSeq.map(Literal(_).sql).mkString(", ")

Review comment:
       > If you don't mind, please file a separate JIRA issue with a separate 
test case. We need to merge this seperately.
   
   So far, I have not found how to trigger the issue in the `sql` method 
without this fix. I will think of that and try tomorrow but if you have some 
ideas you are welcome.
   
   What I have already tried is to build a dataset with IsIn, optimizer 
converts it to InSet but I wasn't able to call `sql()` on the replaced 
expression.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to