MaxGekk commented on a change in pull request #28328:
URL: https://github.com/apache/spark/pull/28328#discussion_r415521493
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -426,7 +426,10 @@ case class In(value: Expression, list: Seq[Expression])
extends Predicate {
* Optimized version of In clause, when all filter values of In clause are
* static.
*/
-case class InSet(child: Expression, hset: Set[Any]) extends UnaryExpression
with Predicate {
+case class InSet(
+ child: Expression,
+ hset: Set[Any],
+ hsetElemType: DataType) extends UnaryExpression with Predicate {
Review comment:
When InSet is created from isInCollection, in that case `child.dataType`
is `NullType`. For example, it is NullType in the test
https://github.com/apache/spark/pull/28328/files#diff-aa655ba249e00d2591b21cf6a360cf82R886
because child is PrettyAttribute when the `sql` method is called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
