MaxGekk commented on a change in pull request #28328:
URL: https://github.com/apache/spark/pull/28328#discussion_r415525400



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -426,7 +426,10 @@ case class In(value: Expression, list: Seq[Expression]) 
extends Predicate {
  * Optimized version of In clause, when all filter values of In clause are
  * static.
  */
-case class InSet(child: Expression, hset: Set[Any]) extends UnaryExpression 
with Predicate {
+case class InSet(
+    child: Expression,
+    hset: Set[Any],
+    hsetElemType: DataType) extends UnaryExpression with Predicate {

Review comment:
       And `InSet.sql()` is called from `Dataset.select` _.named:
   ```scala
   Project(untypedCols.map(_.named), logicalPlan)
   ```
   The `named` method calls `toPrettySQL(expr)`:
   ```scala
   case expr: Expression => Alias(expr, toPrettySQL(expr))()
   ```
   The `toPrettySQL` method calls `sql`:
   ```scala
   def toPrettySQL(e: Expression): String = usePrettyExpression(e).sql
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to