Github user jkbradley commented on the pull request:

    https://github.com/apache/spark/pull/3636#issuecomment-80626659
  
    @Lewuathe  Was a decision made about @mengxr 's suggestion about using 
relative convergence tolerance (instead of absolute, which is used by this PR 
currently)?  LBFGS (via Breeze) uses relative tolerance, so I'm pretty 
convinced we should use relative tolerance.
    
    (We need to document this for LBFGS too!  I just made a JIRA for that.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to