Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3636#issuecomment-82005205
With this change, we should probably constrain convergenceTol to be in [0,
1]. Could you please add that to the doc & add a check in setConvergenceTol?
Also, it should be made clear in the doc that the norm being used for
measuring convergence is the L2 norm.
Thanks! I think the logic is good now, and just a few cleanups remain.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
