gatorsmile commented on a change in pull request #28377:
URL: https://github.com/apache/spark/pull/28377#discussion_r416230516
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Column.scala
##########
@@ -1016,17 +1010,11 @@ class Column(val expr: Expression) extends Logging {
* df.select($"colA".name("colB"))
* }}}
*
- * If the current column has metadata associated with it, this metadata will
be propagated
- * to the new column. If this not desired, use `as` with explicitly empty
metadata.
Review comment:
I think we should keep them. The original comments are still valid. If
users want to block metadata propagation, they should call the API `as(alias:
String, metadata: Metadata):` with an empty metadata.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
