gatorsmile commented on a change in pull request #28377:
URL: https://github.com/apache/spark/pull/28377#discussion_r416232467
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Column.scala
##########
@@ -1016,17 +1010,11 @@ class Column(val expr: Expression) extends Logging {
* df.select($"colA".name("colB"))
* }}}
*
- * If the current column has metadata associated with it, this metadata will
be propagated
- * to the new column. If this not desired, use `as` with explicitly empty
metadata.
Review comment:
To me, it sounds like they are the same to our end users.
I do not have a strong opinion on this. Feel free to rewrite it. When
writing the user-facing comments, please avoid explaining the implementation
details. We just need to document the external impact and behaviors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
