MichaelChirico commented on a change in pull request #28365:
URL: https://github.com/apache/spark/pull/28365#discussion_r417036409
##########
File path: R/pkg/R/DataFrame.R
##########
@@ -2609,18 +2608,17 @@ setMethod("join",
if (is.null(joinType)) {
sdf <- callJMethod(x@sdf, "join", y@sdf, joinExpr@jc)
} else {
- if (joinType %in% c("inner", "cross",
+ valid_join_types <- c("inner", "cross",
"outer", "full", "fullouter", "full_outer",
"left", "leftouter", "left_outer",
"right", "rightouter", "right_outer",
- "semi", "left_semi", "leftsemi", "anti", "left_anti",
"leftanti")) {
+ "semi", "left_semi", "leftsemi", "anti", "left_anti",
"leftanti")
Review comment:
noting here that i changed this error message slightly (removed the or
and aligned the ordering (leftsemi/left_semi and leftanti/left_anti are swapped
vis-a-vis the %in% condition).
it may be preferable to just change the test not to be so exact. LMK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
