cloud-fan commented on a change in pull request #26624:
URL: https://github.com/apache/spark/pull/26624#discussion_r417795158
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -104,7 +104,7 @@ private[spark] class Executor(
.setNameFormat("Executor task launch worker-%d")
.setThreadFactory((r: Runnable) => new UninterruptibleThread(r,
"unused"))
.build()
-
Executors.newCachedThreadPool(threadFactory).asInstanceOf[ThreadPoolExecutor]
+ ThreadUtils.newCachedThreadPool(threadFactory)
Review comment:
Do we need this change? This thread pool is used to execute
`TaskRunner`, which already sets MDC by itself, in
https://github.com/apache/spark/pull/26624/files#diff-5a0de266c82b95adb47d9bca714e1f1bR380
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
