igreenfield commented on a change in pull request #26624:
URL: https://github.com/apache/spark/pull/26624#discussion_r417808048
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -104,7 +104,7 @@ private[spark] class Executor(
.setNameFormat("Executor task launch worker-%d")
.setThreadFactory((r: Runnable) => new UninterruptibleThread(r,
"unused"))
.build()
-
Executors.newCachedThreadPool(threadFactory).asInstanceOf[ThreadPoolExecutor]
+ ThreadUtils.newCachedThreadPool(threadFactory)
Review comment:
1. I think in any case it better to reuse the same code in all places.
2. in case later someone will add MDC set in the caller thread it will not
pass without that.
so I think it good to use it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
