dongjoon-hyun commented on a change in pull request #28416:
URL: https://github.com/apache/spark/pull/28416#discussion_r418307375
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockHandler.java
##########
@@ -242,7 +240,6 @@ public ShuffleMetrics() {
allMetrics.put("registeredExecutorsSize",
(Gauge<Integer>) () ->
blockManager.getRegisteredExecutorsSize());
allMetrics.put("numActiveConnections", activeConnections);
- allMetrics.put("numRegisteredConnections", registeredConnections);
Review comment:
Ur, this might remove this metric from the other resource managers like
`Mesos`. Are you sure about the side-effect?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
