dongjoon-hyun commented on a change in pull request #28416:
URL: https://github.com/apache/spark/pull/28416#discussion_r418310844
##########
File path:
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
##########
@@ -198,6 +198,7 @@ protected void serviceInit(Configuration conf) throws
Exception {
// register metrics on the block handler into the Node Manager's metrics
system.
blockHandler.getAllMetrics().getMetrics().put("numRegisteredConnections",
shuffleServer.getRegisteredConnections());
+
blockHandler.getAllMetrics().getMetrics().putAll(shuffleServer.getAllMetrics().getMetrics());
Review comment:
This one-line seems to be the intended contribution. Did you face some
error with `numRegisteredConnections` while adding this? I'm wondering if there
is a reason to remove `numRegisteredConnections`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
