maropu commented on a change in pull request #28428:
URL: https://github.com/apache/spark/pull/28428#discussion_r418757893



##########
File path: docs/sql-ref-identifier.md
##########
@@ -64,6 +64,7 @@ Note: If `spark.sql.ansi.enabled` is set to true, ANSI SQL 
reserved keywords can
 {% highlight sql %}
 -- This CREATE TABLE fails with ParseException because of the illegal 
identifier name a.b
 CREATE TABLE test (a.b int);
+-- output

Review comment:
       I think adding `-- output` there looks okay, WDYT?
   ```
   INSERT INTO t VALUES ('1');
   -- output
     org.apache.spark.sql.AnalysisException: Cannot write incompatible data to 
table '`default`.`t`':
     - Cannot safely cast 'v': StringType to IntegerType;
   ```
   Could you check documents in the other DBMS-like systems? As the others 
suggested, I think its better to follow the other document formats.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to