huaxingao commented on a change in pull request #28428:
URL: https://github.com/apache/spark/pull/28428#discussion_r418775576



##########
File path: docs/sql-ref-identifier.md
##########
@@ -64,6 +64,7 @@ Note: If `spark.sql.ansi.enabled` is set to true, ANSI SQL 
reserved keywords can
 {% highlight sql %}
 -- This CREATE TABLE fails with ParseException because of the illegal 
identifier name a.b
 CREATE TABLE test (a.b int);
+-- output

Review comment:
       I googled, but didn't have much luck. Only found this one at 
https://docs.snowflake.com/en/sql-reference/functions/validate.html
   
   <img width="1034" alt="Screen Shot 2020-05-01 at 4 08 33 PM" 
src="https://user-images.githubusercontent.com/13592258/80847958-64d9c400-8bc6-11ea-9f4b-312750030b40.png";>
   
   I personally like to either put ```-- output``` or indent 2 spaces for the 
error message, or both (the way you suggested)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to