Github user freeman-lab commented on a diff in the pull request:
https://github.com/apache/spark/pull/5037#discussion_r26498476
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionWithSGD.scala
---
@@ -59,6 +59,8 @@ class StreamingLinearRegressionWithSGD private[mllib] (
val algorithm = new LinearRegressionWithSGD(stepSize, numIterations,
miniBatchFraction)
+ var model: Option[LinearRegressionModel] = None
--- End diff --
Thanks for reviewing @srowen , I'm a little puzzled myself, but undoing
either one of these changes definitely causes failures in the newly added
tests. My guess is it has something to do with how the closure cleaner handles
these vars, which may be affected both by the declaration and the function def,
but will need to dig in more to understand fully. Hoping @tdas might have some
ideas as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
