Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5037#discussion_r26501033
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionWithSGD.scala
---
@@ -59,6 +59,8 @@ class StreamingLinearRegressionWithSGD private[mllib] (
val algorithm = new LinearRegressionWithSGD(stepSize, numIterations,
miniBatchFraction)
+ var model: Option[LinearRegressionModel] = None
--- End diff --
I mean, write a getter/setter for `model` as a test. Right now it looks
like you're just shadowing the member in the superclass? That doesn't seem
right, like, this 'works' for the wrong reason.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
