HyukjinKwon commented on a change in pull request #28442:
URL: https://github.com/apache/spark/pull/28442#discussion_r420536516
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala
##########
@@ -131,11 +130,7 @@ class KafkaTestUtils(
}
private def setUpMiniKdc(): Unit = {
- val kdcDir = Utils.createTempDir()
Review comment:
Yeah, can we just use `eventually` instead of having another class? This
is in the guide, see also
https://github.com/databricks/scala-style-guide#misc_well_tested_method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
