gaborgsomogyi commented on a change in pull request #28442:
URL: https://github.com/apache/spark/pull/28442#discussion_r420807799
##########
File path:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala
##########
@@ -131,11 +130,7 @@ class KafkaTestUtils(
}
private def setUpMiniKdc(): Unit = {
- val kdcDir = Utils.createTempDir()
Review comment:
I agree to use `eventually` in general but the actual code copy-pastes
~20 lines. I think a helper represents value. Without helper several places
must be fixed if any modification needed which not all the time discovered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
