retronym commented on a change in pull request #28463:
URL: https://github.com/apache/spark/pull/28463#discussion_r421417717
##########
File path: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala
##########
@@ -414,6 +433,142 @@ private[spark] object ClosureCleaner extends Logging {
}
}
+private[spark] object IndylambdaScalaClosures extends Logging {
+ // internal name of java.lang.invoke.LambdaMetafactory
+ val LambdaMetafactoryClassName = "java/lang/invoke/LambdaMetafactory"
+ // the method that Scala indylambda use for bootstrap method
+ val LambdaMetafactoryMethodName = "altMetafactory"
+ val LambdaMetafactoryMethodDesc = "(Ljava/lang/invoke/MethodHandles$Lookup;"
+
+ "Ljava/lang/String;Ljava/lang/invoke/MethodType;[Ljava/lang/Object;)" +
+ "Ljava/lang/invoke/CallSite;"
+
+ /**
+ * Check if the given reference is a indylambda style Scala closure.
+ * If so, return a non-empty serialization proxy (SerializedLambda) of the
closure;
+ * otherwise return None.
+ *
+ * @param maybeClosure the closure to check.
+ */
+ def getSerializationProxy(maybeClosure: AnyRef): Option[SerializedLambda] = {
+ val maybeClosureClass = maybeClosure.getClass
+
+ // shortcut the fast check:
+ // indylambda closure classes are generated by Java's LambdaMetafactory,
and they're always
+ // synthetic.
+ if (!maybeClosureClass.isSynthetic) return None
+
+ val implementedInterfaces =
ClassUtils.getAllInterfaces(maybeClosureClass).asScala
+ val isClosureCandidate = implementedInterfaces.exists(_.getName ==
"scala.Serializable") &&
Review comment:
Yep, that should work fine.
Scala lambdas can also implement other functional interfaces (such as
`java.util.function.Supplier`) when used in a context that expects one. I guess
that's out of scope for `ClosureCleaner`, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
