rednaxelafx commented on a change in pull request #28463:
URL: https://github.com/apache/spark/pull/28463#discussion_r421914420
##########
File path: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala
##########
@@ -239,12 +209,12 @@ private[spark] object ClosureCleaner extends Logging {
cleanTransitively: Boolean,
accessedFields: Map[Class[_], Set[String]]): Unit = {
- // most likely to be the case with 2.12, 2.13
+ // indylambda check. Most likely to be the case with 2.12, 2.13
// so we check first
// non LMF-closures should be less frequent from now on
- val lambdaFunc = getSerializedLambda(func)
+ val maybeIndylambdaProxy =
IndylambdaScalaClosures.getSerializationProxy(func)
Review comment:
Right, the new `IndylambdaScalaClosures.getSerializationProxy` is pretty
much the same as the old `getSerializedLambda`, just with a few more checks.
It's supposed to return `None` for Scala 2.11 closures, and `Some(...)` for
Scala 2.12+ closures, no changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
