cloud-fan commented on a change in pull request #28511:
URL: https://github.com/apache/spark/pull/28511#discussion_r425651583
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
##########
@@ -281,11 +284,27 @@ case class InsertIntoHiveTable(
oldPart.flatMap(_.storage.locationUri.map(uri => new Path(uri)))
}
+ val hiveVersion =
externalCatalog.asInstanceOf[ExternalCatalogWithListener]
+ .unwrapped.asInstanceOf[HiveExternalCatalog]
+ .client
+ .version
+ // https://issues.apache.org/jira/browse/SPARK-31684,
+ // For Hive 2.0.0 and onwards, as
https://issues.apache.org/jira/browse/HIVE-11940
+ // has been fixed, and there is no performance issue anymore.
Review comment:
This code block was there for a long time, would be better to re-run
benchmark now, to make sure we don't introduce regressio.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
