cloud-fan commented on a change in pull request #28511:
URL: https://github.com/apache/spark/pull/28511#discussion_r426618435
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/package.scala
##########
@@ -22,7 +22,19 @@ package object client {
private[hive] sealed abstract class HiveVersion(
val fullVersion: String,
val extraDeps: Seq[String] = Nil,
- val exclusions: Seq[String] = Nil)
+ val exclusions: Seq[String] = Nil) extends Ordered[HiveVersion] {
+ override def compare(that: HiveVersion): Int = {
+ val thisVersionParts = fullVersion.split('.').map(_.toInt)
+ val thatVersionParts = that.fullVersion.split('.').map(_.toInt)
+ thisVersionParts.zip(thatVersionParts).foreach { case (l, r) =>
Review comment:
can we add an assert that
`thisVersionParts.sameLength(thatVersionParts)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
