bart-samwel commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r427165637
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -846,6 +857,15 @@ abstract class ToTimestamp
case NonFatal(_) => null
}
}
+ case LongType =>
+ val input = t.asInstanceOf[Long]
+ if ( minRange < input && input < maxRange ) {
+ Math.multiplyExact(input, scaleFactor.asInstanceOf[Long])
Review comment:
My earlier concern was about whether we support the full range of Long
as valid timestamps, or if the actual supported range is smaller. I googled a
bit, and it seems that the full range is supported. So that's fine then without
checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
