cloud-fan commented on a change in pull request #28534:
URL: https://github.com/apache/spark/pull/28534#discussion_r427286094
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -401,6 +401,92 @@ case class DayOfYear(child: Expression) extends
UnaryExpression with ImplicitCas
}
}
+@ExpressionDescription(
+ usage = "_FUNC_(date) - Returns timestamp from seconds.",
+ examples = """
+ Examples:
+ > SELECT _FUNC_(1230219000);
+ "2008-12-25 07:30:00.0"
+ """,
+ group = "datetime_funcs",
+ since = "3.1.0")
+case class SecondsToTimestamp(child: Expression)
+ extends NumberToTimestampBase {
+
+ override def upScaleFactor: SQLTimestamp = MICROS_PER_SECOND
+
+ override def prettyName: String = "timestamp_seconds"
+}
+
+@ExpressionDescription(
+ usage = "_FUNC_(date) - Returns timestamp from milliseconds.",
+ examples = """
+ Examples:
+ > SELECT _FUNC_(1230219000000);
+ "2008-12-25 07:30:00.0"
+ """,
+ group = "datetime_funcs",
+ since = "3.1.0")
+case class MilliSecondsToTimestamp(child: Expression)
+ extends NumberToTimestampBase {
+
+ override def upScaleFactor: SQLTimestamp = MICROS_PER_MILLIS
+
+ override def prettyName: String = "timestamp_milliseconds"
+}
+
+@ExpressionDescription(
+ usage = "_FUNC_(date) - Returns timestamp from microseconds.",
+ examples = """
+ Examples:
+ > SELECT _FUNC_(1230219000000000);
+ "2008-12-25 07:30:00.0"
+ """,
+ group = "datetime_funcs",
+ since = "3.1.0")
+case class MicroSecondsToTimestamp(child: Expression)
+ extends NumberToTimestampBase {
+
+ override def upScaleFactor: SQLTimestamp = 1L
+
+ override def prettyName: String = "timestamp_microseconds"
+}
+
+abstract class NumberToTimestampBase extends UnaryExpression
+ with ImplicitCastInputTypes{
+
+ protected def upScaleFactor: Long
+
+ override def inputTypes: Seq[AbstractDataType] = Seq(LongType, IntegerType)
Review comment:
we should accept `LongType` only. The analyzer will cast the input to
long for you, if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
